Bump Pulp squeezer to latest version#2308
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pulp.squeezer collection to version 0.3.0 and refactors artifact and RPM upload tasks to use specialized modules, improving performance. Review feedback suggests pinning the stackhpc.pulp collection to a specific version instead of master to ensure reproducibility and adding retry logic to the OFED RPM upload task for better robustness.
d185ee2 to
bb840ae
Compare
Alex-Welsh
reviewed
May 13, 2026
Bumps Pulp squeezer to version 0.3.0, along with bumping and adding required dependencies. The `chunk_size` parameter has been set to 4194304 bytes in `pulp.squeezer.file_content` tasks to workaround a Python bug[0] relating to SSL errors with large requests (fixed in 3.13). Co-Authored-by: Alex Welsh <alex@stackhpc.com> 0: python/cpython#110467
bb840ae to
9f93466
Compare
Alex-Welsh
approved these changes
May 13, 2026
Member
Alex-Welsh
left a comment
There was a problem hiding this comment.
LGTM, I'd like to see the check-review pipeline run before merging though
Alex-Welsh
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Pulp squeezer to version 0.3.0, along with bumping and adding required dependencies.
The
chunk_sizeparameter has been set to 4194304 bytes inpulp.squeezer.file_contenttasks to workaround a Python bug[0] relating to SSL errors with large requests (fixed in 3.13).Co-Authored-by: Alex Welsh alex@stackhpc.com
0: python/cpython#110467